Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add portal https guide #4676

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

add portal https guide

Which issue(s) this PR fixes:

Fixes #4655

Brief changelog

  • add faq about how to enable portal access in nginx with https

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested a review from vdiskg December 9, 2022 11:04
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #4676 (17d3e81) into master (8ddbe0a) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 17d3e81 differs from pull request most recent head a923ef3. Consider uploading reports for the commit a923ef3 to get more accurate results

@@             Coverage Diff              @@
##             master    #4676      +/-   ##
============================================
- Coverage     47.16%   47.07%   -0.10%     
+ Complexity     1647     1644       -3     
============================================
  Files           347      347              
  Lines         10643    10643              
  Branches       1057     1057              
============================================
- Hits           5020     5010      -10     
- Misses         5321     5330       +9     
- Partials        302      303       +1     
Impacted Files Coverage Δ
...oServiceRegistryDeregisterApplicationListener.java 30.00% <0.00%> (-45.00%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@vdiskg vdiskg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit c523af6 into apolloconfig:master Dec 14, 2022
@nobodyiam nobodyiam deleted the add-portal-https-guide branch December 14, 2022 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApolloPortal still access http with nginx https reverse proxy
2 participants